crepererum commented on code in PR #14366:
URL: https://github.com/apache/datafusion/pull/14366#discussion_r1935282817
##########
datafusion/expr/src/expr.rs:
##########
@@ -297,7 +298,7 @@ pub enum Expr {
/// [`ExprFunctionExt`]: crate::expr_fn::ExprFunctionExt
AggregateFunction(AggregateFunction),
/// Represents the call of a window function with arguments.
- WindowFunction(WindowFunction),
+ WindowFunction(Box<WindowFunction>), // Boxed as it is large (272 bytes)
Review Comment:
the concrete byte count is likely out-of-date soon, so I would just exclude
it from the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
