alamb commented on code in PR #14366:
URL: https://github.com/apache/datafusion/pull/14366#discussion_r1934699879
##########
datafusion/expr/src/expr.rs:
##########
@@ -297,7 +298,7 @@ pub enum Expr {
/// [`ExprFunctionExt`]: crate::expr_fn::ExprFunctionExt
AggregateFunction(AggregateFunction),
/// Represents the call of a window function with arguments.
- WindowFunction(WindowFunction),
+ WindowFunction(Box<WindowFunction>), // Boxed as it is large (272 bytes)
Review Comment:
This is the API change in this PR: it moves a "large" structure (272 bytes)
on to the heap
the rest of the changes follow from this one change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
