Chen-Yuan-Lai commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2679115258
Hi @jayzhan211, I encountered some CI failures in the `digest` function. It
seems the `Exact(vec![Utf8View, Utf8View])` case can't be replaced with
`TypeSignature::Coercible` because `TypeSignature::Coercible` processes each
parameter independently, without considering the types of other parameters
```bash
[SQL] EXPLAIN SELECT
digest(column1_utf8view, 'md5') as c
FROM test;
[Diff] (-expected|+actual)
logical_plan
- 01)Projection: digest(test.column1_utf8view, Utf8View("md5")) AS c
+ 01)Projection: digest(test.column1_utf8view, Utf8("md5")) AS c
02)--TableScan: test projection=[column1_utf8view]
```
Should we:
1. Implement a new `TypeSignature::Coercible` method to support this feature?
2. Mixing the usage `TypeSignature::Coercible` and `Exact(vec![Utf8View,
Utf8View])` in `digest` function?
I'm not sure which one is better, could you give me some suggestions or
other best practices? thanks very much!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
