gabotechs commented on code in PR #15482:
URL: https://github.com/apache/datafusion/pull/15482#discussion_r2024939228
##########
datafusion/sqllogictest/test_files/push_down_filter.slt:
##########
@@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a],
full_filters=[t.a != Int32(100)]
query TT
explain select a from t where a = '99999999999';
----
Review Comment:
I imagine that instead of returning an empty plan, we should be expecting a
runtime error here, something like
```suggestion
statement error Cannot coerce '...' to type '...'
explain select a from t where a = '99999999999';
```
I do not see any instance in the sql logic tests that are actually expecting
an empty plan upon an error.
##########
datafusion/sqllogictest/test_files/push_down_filter.slt:
##########
@@ -230,19 +230,19 @@ logical_plan TableScan: t projection=[a],
full_filters=[t.a != Int32(100)]
query TT
explain select a from t where a = '99999999999';
----
-logical_plan TableScan: t projection=[a], full_filters=[CAST(t.a AS Utf8) =
Utf8("99999999999")]
+
Review Comment:
I can confirm that Postgres is also not able to plan for this query for the
same reason: [link to Postgres
fiddle](https://www.db-fiddle.com/f/4jyoMCicNSZpjMt4jFYoz5/16528)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
