berkaysynnada commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2787637557
> > I think we should leave this open for a while to let anyone else who wants time to review (such as @berkaysynnada ) but I think it is mergable > > @berkaysynnada would love to get your input here, hoping we can confirm these APIs will work for the JOIN use cases 🙏🏻 I'm sorry, cannot finish the review yet(looking at https://github.com/apache/datafusion/pull/15568 as well). I could understand what you are trying to do, and both PR's seem very good, but I am taking notes of some points to discuss. After finalizing these 2, I'll share them with you (hopefully tomorrow morning). Thank you for your patience 😞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
