ozankabak commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2796149727
@alamb and @adriangb: Is there a specific urgency to get this merged ASAP? If so, we can do it and then replace the API. However, unless there is a good reason, I think it is a bad idea to have API churn, and increase the total amount of work just to avoid the extra 1-2 days work on this PR. Once this PR merges and the API starts to get used, it becomes hard to replace it (I'm going through this in equivalence code these days). I think the new design is sound and much simpler -- we can add a join example to the doc too, and if everybody agrees we can proceed with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
