adriangb commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040467822


##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
                 )
             })?
             .clone();
-        let inner =
-            Self::remap_children(&self.children, 
self.remapped_children.as_ref(), inner)?;

Review Comment:
   I feel like we're going in circles... this is the thing that was expected to 
be used to produce the snapshots... now we're using snapshots to produce it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to