comphead commented on PR #15861: URL: https://github.com/apache/datafusion/pull/15861#issuecomment-2832426180
Thanks @rroelke Started the flow, added `api-change`. I got the idea about the size, but now its on heap vs stack and we introduce memory roundtrip through indirection. I was just wondering if this Boxing intended to fix the issue or perfomance? if it is the latter it would be good to check planner bench like https://github.com/apache/datafusion/pull/15796#issuecomment-2823666019 For instance we box here `SchemaError(SchemaError, Box<Option<String>>),` but this is caused by the error details was too large and sometimes lead to stackoverflows and we moved it to the heap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
