rroelke commented on PR #15861: URL: https://github.com/apache/datafusion/pull/15861#issuecomment-2835010666
> > Whereas the DataFusion::AvroError is only produced by the avro reader but it affects every place where DataFusionError can appear. > > How about we convert the error into the string and wrap with other datafusion error, so we can avoid this variant entirely IMO we should not convert errors to strings at all, downstream library or application code should not be asked to possibly parse error messages. I would be happy to submit a follow-up PR to add a new variant wrapping `Box<dyn Error + 'static>` or change `Other` to have that data instead. But I don't see a reason that this PR should pivot in that direction. Can you articulate your objection to the current diff more precisely please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
