klemniops commented on code in PR #15861:
URL: https://github.com/apache/datafusion/pull/15861#discussion_r2062687991
##########
datafusion/common/src/error.rs:
##########
@@ -59,7 +59,7 @@ pub enum DataFusionError {
ParquetError(ParquetError),
/// Error when reading Avro data.
#[cfg(feature = "avro")]
- AvroError(AvroError),
+ AvroError(Box<AvroError>),
Review Comment:
I'd favor that. There might be another error variant which is less than the
clippy threshold size but is still large enough to prevent certain
optimizations. If all the error variants were boxed then we could be confident
that `DataFusionError` could be copied around in registers and then perhaps
`Result<T, DataFusionError>` also could be for small `T`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
