jayzhan211 commented on PR #15861: URL: https://github.com/apache/datafusion/pull/15861#issuecomment-2832938364
https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant Based on the description, I think we box is when 1. the variant is rarely used 2. it improves the performance I think this error is not rarely used so I think it is better we have number shows this helps performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
