comphead commented on PR #15861: URL: https://github.com/apache/datafusion/pull/15861#issuecomment-2832457524
I just checked AvroError, its actually the wrapper of apache-avro internal and some variants can be pretty large. to avoid possible stackoverflow it make sense moving it to heap like clippy suggested 🤔 btw we dont have a good bench against avro. Lets go with clippy suggestion here, although it is `MaybeIncorrect` applicability https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
