alamb commented on code in PR #15861:
URL: https://github.com/apache/datafusion/pull/15861#discussion_r2063840145
##########
datafusion/common/src/error.rs:
##########
@@ -59,7 +59,7 @@ pub enum DataFusionError {
ParquetError(ParquetError),
/// Error when reading Avro data.
#[cfg(feature = "avro")]
- AvroError(AvroError),
+ AvroError(Box<AvroError>),
Review Comment:
I personally suggest avoiding additional API churn (aka boxing all varaints)
unless there is some particular problem we are trying to solve or improve
performance in some way we can measure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
