gabotechs commented on issue #15069: URL: https://github.com/apache/datafusion/issues/15069#issuecomment-2890872232
> One idea that comes to mind is to be able to run the sqllogictests in "substrait roundrip" mode. Upon building a logical DataFusion plan, it would be converted to Substrait and then back to DataFusion logical for each sqllogictest statement. I've explored this idea in - https://github.com/gabotechs/datafusion/pull/6 which builds on top of - https://github.com/apache/datafusion/pull/16029 And I'm quite happy with the result. It does seem like this approach is catching relevant bugs, and the idea of creating scoped issues with a reproducer as portable as ```shell cargo test --test sqllogictests -- --substrait-round-trip aggregate:1522 ``` leads me to think that it can incentivize people to contribute fixes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
