gabotechs commented on issue #15069: URL: https://github.com/apache/datafusion/issues/15069#issuecomment-2893161350
That sounds reasonable, although given the current state there's a lot of ignoring to be done in the Substrait validation mode, some numbers here: currently out of 7302 `query` sqllogictest statements, only 3583 are passing in Substrait validation mode, which means that we'll need to add 3719 `skipif DataFusionSubstraitRoundTrip` (or similar) lines above each individual test that fails. Some options here: 1. Add those 3719 `skipif DataFusionSubstraitRoundTrip` lines along with CI pipelines that run the sqllogictest in Substrait validation mode 2. Don't enforce Substrait validation immediately, and do some rounds solving the bugs that contribute the most errors in order to lower that number, and then do 1. 3. Don't enforce Substrait validation, and rely on contributors manually running them with the `--substrait-round-trip` flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
