alamb commented on issue #15069: URL: https://github.com/apache/datafusion/issues/15069#issuecomment-2891691270
> And I'm quite happy with the result. It does seem like this approach is catching relevant bugs, and the idea of creating scoped issues with a reproducer as portable as Perhaps what we can do is to 1. Add a new CI job / phase of an existing job to run sqllogictests with substrait validation 1. Add some way to ignore a test / exclude it from running in substrait validation mode (to avoid blocking PRs that are unrelated but find a substrait bug with new tests) 2. File a ticket with the goal of "get all tests running in substrait validation mode" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
