ding-young commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2287003717


##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -396,12 +455,30 @@ impl ExternalSorter {
                 Some((self.spill_manager.create_in_progress_file("Sorting")?, 
0));
         }
 
+        // Slice only the last batch if it's too large.

Review Comment:
   I agree, I’ll also investigate why this happens and whether we can address 
it earlier. :thinking: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to