rluvaton commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2288398140
##########
datafusion/core/tests/fuzz_cases/spilling_fuzz_in_memory_constrained_env.rs:
##########
@@ -78,11 +78,7 @@ async fn test_sort_with_limited_memory() -> Result<()> {
})
.await?;
- let total_spill_files_size = spill_count * record_batch_size;
- assert!(
- total_spill_files_size > pool_size,
- "Total spill files size {total_spill_files_size} should be greater than
pool size {pool_size}",
- );
+ assert!(spill_count > 0);
Review Comment:
the reason why I added it is to make sure that this test does not allow
having a batch from each spill in memory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
