rluvaton commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2288424684
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -415,6 +492,8 @@ impl ExternalSorter {
(*max_record_batch_size).max(batch.get_sliced_size()?);
}
+ self.reservation.free();
+
Review Comment:
because `in_progress_file` does not reserve any memory right now it is fine,
however if in progress file will add a `BufWriter` and it should also reserve
memory by that buffer than this will be a problem and we should have a
"transaction" to move reservation between consumer.
but for now it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
