rluvaton commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2288458627
##########
datafusion/physical-plan/src/sorts/streaming_merge.rs:
##########
@@ -88,6 +88,10 @@ pub struct StreamingMergeBuilder<'a> {
fetch: Option<usize>,
reservation: Option<MemoryReservation>,
enable_round_robin_tie_breaker: bool,
+ /// Ratio of memory used by cursor batch to the original input RecordBatch.
Review Comment:
why is this part of the public API if it depend on internal cursor
implementation?
##########
datafusion/physical-plan/src/sorts/streaming_merge.rs:
##########
@@ -146,6 +150,11 @@ impl<'a> StreamingMergeBuilder<'a> {
self
}
+ pub fn with_cursor_batch_ratio(mut self, ratio: Option<f64>) -> Self {
Review Comment:
why is this part of the public API if it depend on internal cursor
implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
