ding-young commented on code in PR #17163:
URL: https://github.com/apache/datafusion/pull/17163#discussion_r2289645588
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -673,14 +756,13 @@ impl ExternalSorter {
.into_iter()
.map(|batch| {
let metrics = self.metrics.baseline.intermediate();
- let reservation = self
- .reservation
- .split(get_reserved_byte_for_record_batch(&batch));
+ let reservation = self.reservation.split(
+ get_reserved_byte_for_record_batch(&batch,
self.cursor_batch_ratio),
+ );
Review Comment:
yes, we don't need the `cursor_batch_ratio` here and we need to pass `none`
to provide default 2x ratio. I'll update the benchmark results after fixing
these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
