andygrove commented on code in PR #2604:
URL: https://github.com/apache/datafusion-comet/pull/2604#discussion_r2470764287
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -164,6 +164,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
classOf[BitLength] -> CometScalarFunction("bit_length"),
classOf[Chr] -> CometScalarFunction("char"),
classOf[ConcatWs] -> CometScalarFunction("concat_ws"),
+ classOf[Concat] -> CometScalarFunction("concat"),
Review Comment:
I think we need type checks so that we fall back to Spark for unsupported
argument types?
Perhaps something like this?
```scala
object CometConcat extends CometScalarFunction[Concat]("concat") {
override def getSupportLevel(expr: Concat): SupportLevel = {
if (expr.children.forall(_.dataType == DataTypes.StringType)) {
Compatible()
} else {
Incompatible(Some("Only string arguments are supported"))
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
