andygrove commented on code in PR #2604:
URL: https://github.com/apache/datafusion-comet/pull/2604#discussion_r2470777178
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -3144,4 +3144,44 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("test concat function - strings") {
+ withTable("t1") {
+ sql(
+ "create table t1 using parquet as select uuid() c1, uuid() c2, uuid()
c3, uuid() c4, cast(null as string) c5 from range(10)")
+ checkSparkAnswerAndOperator("select concat(c1, c2) AS x FROM t1")
+ checkSparkAnswerAndOperator("select concat(c1, c1) AS x FROM t1")
+ checkSparkAnswerAndOperator("select concat(c1, c2, c3) AS x FROM t1")
+ checkSparkAnswerAndOperator("select concat(c1, c2, c3, c5) AS x FROM t1")
+ checkSparkAnswerAndOperator(
+ "select concat(concat(c1, c2, c3), concat(c1, c3)) AS x FROM t1")
+ }
+ }
+
+ // https://github.com/apache/datafusion-comet/issues/2647
+ ignore("test concat function - arrays") {
Review Comment:
Could you enable these tests and use the recently added
`checkSparkAnswerAndFallbackReason` method to make sure we are correctly
falling back to Spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
