andygrove commented on code in PR #2604: URL: https://github.com/apache/datafusion-comet/pull/2604#discussion_r2470772858
########## spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q5.native_iceberg_compat/explain.txt: ########## @@ -1,78 +1,75 @@ == Physical Plan == -TakeOrderedAndProject (74) -+- * HashAggregate (73) - +- * CometColumnarToRow (72) - +- CometColumnarExchange (71) - +- * HashAggregate (70) - +- * Expand (69) - +- Union (68) - :- * HashAggregate (23) - : +- * CometColumnarToRow (22) - : +- CometExchange (21) - : +- CometHashAggregate (20) - : +- CometProject (19) - : +- CometBroadcastHashJoin (18) - : :- CometProject (13) - : : +- CometBroadcastHashJoin (12) - : : :- CometUnion (7) - : : : :- CometProject (3) - : : : : +- CometFilter (2) - : : : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store_sales (1) - : : : +- CometProject (6) - : : : +- CometFilter (5) - : : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store_returns (4) - : : +- CometBroadcastExchange (11) - : : +- CometProject (10) - : : +- CometFilter (9) - : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.date_dim (8) - : +- CometBroadcastExchange (17) - : +- CometProject (16) - : +- CometFilter (15) - : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store (14) - :- * HashAggregate (43) - : +- * CometColumnarToRow (42) - : +- CometExchange (41) - : +- CometHashAggregate (40) - : +- CometProject (39) - : +- CometBroadcastHashJoin (38) - : :- CometProject (33) - : : +- CometBroadcastHashJoin (32) - : : :- CometUnion (30) - : : : :- CometProject (26) - : : : : +- CometFilter (25) - : : : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.catalog_sales (24) - : : : +- CometProject (29) - : : : +- CometFilter (28) - : : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.catalog_returns (27) - : : +- ReusedExchange (31) - : +- CometBroadcastExchange (37) - : +- CometProject (36) - : +- CometFilter (35) - : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.catalog_page (34) - +- * HashAggregate (67) - +- * CometColumnarToRow (66) - +- CometExchange (65) - +- CometHashAggregate (64) - +- CometProject (63) - +- CometBroadcastHashJoin (62) - :- CometProject (57) - : +- CometBroadcastHashJoin (56) - : :- CometUnion (54) - : : :- CometProject (46) - : : : +- CometFilter (45) - : : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.web_sales (44) - : : +- CometProject (53) - : : +- CometBroadcastHashJoin (52) - : : :- CometBroadcastExchange (48) - : : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.web_returns (47) - : : +- CometProject (51) - : : +- CometFilter (50) - : : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.web_sales (49) - : +- ReusedExchange (55) - +- CometBroadcastExchange (61) - +- CometProject (60) - +- CometFilter (59) - +- CometScan [native_iceberg_compat] parquet spark_catalog.default.web_site (58) +* CometColumnarToRow (71) ++- CometTakeOrderedAndProject (70) + +- CometHashAggregate (69) + +- CometExchange (68) + +- CometHashAggregate (67) + +- CometExpand (66) + +- CometUnion (65) + :- CometHashAggregate (22) Review Comment: Why is this hash aggregate now supported in Comet? I don't see `concat` used in the query. https://github.com/apache/datafusion-benchmarks/blob/main/tpcds/queries-spark/q5.sql -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
