andygrove commented on code in PR #2604:
URL: https://github.com/apache/datafusion-comet/pull/2604#discussion_r2470766556
##########
fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala:
##########
@@ -137,6 +137,10 @@ object Meta {
SparkBinaryType,
SparkArrayType(
SparkTypeOneOf(Seq(SparkStringType, SparkNumericType,
SparkBinaryType))))))),
+ createFunctionWithInputTypes(
+ "concat",
+ Seq(SparkStringType, SparkStringType)
+ ), // TODO: variadic
Review Comment:
I know that this PR is just to support string inputs in Comet concat, but
the fuzz tester should ideally test for all types that Spark supports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
