JakeChampion commented on code in PR #12201: URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2281743615
########## include/tscore/ink_config.h.cmake.in: ########## @@ -187,3 +187,5 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@; #cmakedefine YAMLCPP_LIB_VERSION "@YAMLCPP_LIB_VERSION@" #cmakedefine01 TS_HAS_CRIPTS + +#cmakedefine HAVE_ZSTD_H 1 Review Comment: The intention is for the feature to be toggled via the compress plugin options, similar to how the compress plugin introduced brotli compression support. If someone configures the compress plugin to use zstd and they do not have it available, it will error with: >error("supported-algorithms: zstd support not compiled in."); from https://github.com/apache/trafficserver/pull/12201/files#diff-908cc31df4fc1801284333e04798e2c8a9b1f4e2cb31ca97bb16f24839e0ac28R236-R241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org