JosiahWI commented on code in PR #12201: URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2283664657
########## plugins/compress/compress.cc: ########## @@ -136,8 +132,15 @@ handle_range_request(TSMBuffer req_buf, TSMLoc req_loc, HostConfiguration *hc) } } // namespace +// Forward declarations for ZSTD compression functions +#if HAVE_ZSTD_H +static void zstd_compress_init(Data *data); +static void zstd_compress_finish(Data *data); +static void zstd_compress_one(Data *data, const char *upstream_buffer, int64_t upstream_length); Review Comment: I'm curious why the name is `zstd_compress_one` and not `zstd_compress_update`. I worked on the hashing before and this reminds me of OpenSSL's API, except for that naming difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
