cmcfarlen commented on PR #13063: URL: https://github.com/apache/trafficserver/pull/13063#issuecomment-5605303672
Rebuilt this branch on current `master` and addressed the outstanding review feedback. **Why the diff looked absurd.** The branch had been rebased backwards at some point — `master`'s history was replayed onto it rather than the other way around, leaving 160 commits that were patch-equivalents of other people's merged PRs and a merge base stuck in April. That's what produced the +275k/946-file view and the conflicts. I cherry-picked the 6 real commits onto current `master`; the diff is back to what it should be, 5 files. **@bryancall's review** (`298c1fd37b`): - The `gh` path read *any* non-zero `gh api .../merge` exit as "not merged", so a 403 or 5xx silently dropped merged PRs from the changelog and still exited 0. It now uses `gh api --include` and discriminates on the status line: 204 merged, 404 not merged, anything else is fatal. The `--doc` detail fetch likewise fails loudly instead of substituting an empty sha/body. The `httpx` path was already correct here, as you noted, so it's unchanged. - `--doc` help/docstring corrected to say "PR body", noting that `--from-git` yields the commit message body instead. - `-a/--auth` documented as discouraged (visible in `ps` and shell history) with a pointer to `GH_TOKEN`. - `license = "Apache-2.0"` added, matching `tools/hrw4u` and `tools/traffic_grapher`. **Copilot's follow-up plus one thing it caught that mattered** (`6c262932cf`): - `uv.lock` had been resolved through an internal package mirror, so the registry and every artifact URL were unreachable outside that network. Repointed at `pypi.org`/`files.pythonhosted.org` — versions, sizes and sha256 hashes are unchanged, since it's the same artifacts. Keeping the lock committed per @bneradt's earlier note and the RAT fix in #13066. - The `--from-git` PR-number regex matched `#N` anywhere in the subject rather than the trailing `(#N)` its docstring describes, so `Fix issue #12345 in the cache` captured 12345 as a PR number and could merge unrelated entries. Now anchored. - `_check_rate_limit()` announced a rate limit for every 403, but GitHub also uses 403 for a missing token or insufficient scopes, where that advice is wrong and hides the cause. It now exits only on a primary limit (`x-ratelimit-remaining: 0`), a secondary limit (`retry-after`), or a 429, and lets everything else fall through to the `raise_for_status()` that follows each call site. All 15 checks were green on the previous head. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
