cmcfarlen commented on PR #13063: URL: https://github.com/apache/trafficserver/pull/13063#issuecomment-5608384018
Latest round of Copilot comments handled in `c0a28af23e`; all review threads on the PR are now replied to and resolved. **Fixed:** - `yaml.safe_dump()` instead of `yaml.dump()`, so the output cannot grow Python object tags. - Dropped `[project.scripts]`. This closes out the earlier console-script thread too: with no `[build-system]` table, uv treats this as a virtual project and never builds the package, so the entry point it declared was never created. It described an interface that does not exist and had been read as the supported one twice, so removing it is the honest fix — preferable to adding a build backend for a single-file in-tree script. A comment in its place records the real invocation. - The release guide now names its prerequisites (uv, and an authenticated `gh` for `--use-gh`) and documents the `GH_TOKEN` alternative. Worth being blunt there, so I was: a token is not optional, because an unauthenticated run exceeds the rate limit partway through a release-sized milestone and exits without writing a changelog. I hit exactly that while testing. **Declined,** with reasoning on the thread: batching the `--doc` fetches through GraphQL. It would mean a second, structurally different fetch path alongside REST, in a tool that runs a handful of times per release. 10.2.0 was generated at roughly twice a normal release's PR count without approaching the authenticated limit, and if a future release does trip it, the failure is now loud rather than silent. @bryancall I'll wait for Copilot to have another pass at this before asking you to look again, so you're not reviewing into a moving target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
