cmcfarlen commented on PR #13063: URL: https://github.com/apache/trafficserver/pull/13063#issuecomment-5607368066
@bryancall — went through Copilot's six comments; they're four distinct points (the PyYAML one is repeated three times). Two fixed in `378b586bfe`, two declined with reasoning on the threads. **Fixed:** - **PyYAML required vs optional.** `pyproject.toml` declared it required while the code guarded the import and errored at runtime if missing. `httpx` is imported unconditionally and is equally a third-party dependency, so the guarded path was only reachable from an install `pyproject.toml` doesn't describe. YAML output is a documented mode, so I made the dependency real rather than optional — an extra would have made `--format yaml` fail by default in the workflow the docs describe. - **Dedup within the git range.** `merge_changelogs()` documented dedup by PR number but only deduped across the git/milestone boundary, not within the git range. A revert-and-reapply, or the same commit cherry-picked twice, carries the same trailing `(#N)` and produced two entries for one PR. Now deduped on the git side too, keeping the first occurrence so the surviving entry is the chronological one. **Declined** (detail on the threads): the suggestion to drop the merge check in `--doc` mode would give merged-ness two determination paths across two transports, for a rate-limit saving that doesn't bite at release scale. And the suggested docs change to the console script *doesn't run* — there's no `[build-system]`, so uv treats this as a virtual project and the `[project.scripts]` entry never materializes; `tools/traffic_grapher` has the same shape. Verification on this round: the dedup case tested directly (first occurrence kept, labels grafted onto the survivor, milestone extras and unnumbered security commits intact), plus an authenticated end-to-end `--from-git --doc --format yaml` run against `apache/trafficserver` that produced parseable YAML with no duplicate numbers. Unauthenticated, the same run still exits with the rate-limit message, so that path is confirmed too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
