On Mar 18, 2010, at 11:37 AM, Kevin LaCoste wrote: > On Thu, Mar 18, 2010 at 10:14 AM, Nathan Kinsinger > <[email protected]> wrote: > > Add remote/tag, merge, cherry-pick, rebase: these all operate on the selected > commit. I originally had these at the bottom (where gitx already had a > toolbar) but they felt too far removed from items in the commit list. So I > put them at the top. This is a subjective opinion on my part. > > I'd agree that these items belong in the window toolbar if anywhere at all. > The most used actions are candidates for the default toolbar. I'd say that's > probably branch, rebase and merge. Add remote/tag and cherry-pick would be > better off as options when customizing the toolbar.
In my original branch I had everything in the window's toolbar. Pieter didn't like them there and asked for something along the lines of iPhoto where the items/toolbars were inside the view they worked on. The current UI is my interpretation of this. I may have gone too far by splitting things into multiple sections. I would be very willing to put some/all items back (in the window's toolbar). One good reason is so that people can customize the items they use. (I just realized that "Add remote/tag" in my original comment above should have been "Add branch/tag") > Detail/tree view: After moving the others to the top I tried putting this up > there too. But again it felt too far removed from what it operated on. > > QuickLook: I'm doing this one separately because I think this should be > removed and somehow (I haven't worked out how yet) be linked to the content > view of items in the tree view. I was going to wait on dealing with this > until I added 10.6's QuickLook API to GitX. > > Agreed on the QuickLook button. This doesn't belong on the bottom toolbar. In > fact, this entire bottom toolbar doesn't really fit with GitX's design. If > I'm not mistaken, Apple typically uses/recommends bottom bars for database > type apps like iPhoto and iTunes. GitX is a document based app and as such, > it should probably use a button bar in it's source list if anything. > > We could probably simplify the UI a fair bit by removing the bottom bar > completely. QuickLook would be triggered by the space key when a file is > selected in the Tree View's table and switching between the views could > happen via menu item (with shortcut). I'll keep this in mind and take a look at it when I get to working on QuickLook. Another option would be to imbed a QuickLook view in the content view if it's a file/format GitX doesn't support directly. Hover controls would allow it to go to a larger window or full screen. But we would still need a way for people to view QuickLook versions of formats GitX does support. Of course if anyone has experience making QuickLook work and compile on both 10.5 and 10.6, please go ahead :) > I put the remote operations at the bottom under the source view because they > relate to the selection in the source view and not which commit is selected. > > The standard UI for this is the button bar. See attached screen shot. The > various actions would be available from the gear menu or via contextual menu > in the source list. First of all, all the items except Detail/Tree View and QuickLook are already in contextual menus and in the gear/action menu. But I felt that most needed to have a visual control as well. If the window didn't have the bottom content bar I would have put these in a button bar like you suggested (of course I would probably have been crazy and added icons for the remote operations too). --Nathan http://brotherbard.com/ To unsubscribe from this group, send email to gitx+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
