On Thu, Mar 18, 2010 at 10:14 AM, Nathan Kinsinger < [email protected]> wrote:
Add remote/tag, merge, cherry-pick, rebase: these all operate on the > selected commit. I originally had these at the bottom (where gitx already > had a toolbar) but they felt too far removed from items in the commit list. > So I put them at the top. This is a subjective opinion on my part. > I'd agree that these items belong in the window toolbar if anywhere at all. The most used actions are candidates for the default toolbar. I'd say that's probably branch, rebase and merge. Add remote/tag and cherry-pick would be better off as options when customizing the toolbar. > Detail/tree view: After moving the others to the top I tried putting this > up there too. But again it felt too far removed from what it operated on. > > QuickLook: I'm doing this one separately because I think this should be > removed and somehow (I haven't worked out how yet) be linked to the content > view of items in the tree view. I was going to wait on dealing with this > until I added 10.6's QuickLook API to GitX. > Agreed on the QuickLook button. This doesn't belong on the bottom toolbar. In fact, this entire bottom toolbar doesn't really fit with GitX's design. If I'm not mistaken, Apple typically uses/recommends bottom bars for database type apps like iPhoto and iTunes. GitX is a document based app and as such, it should probably use a button bar in it's source list if anything. We could probably simplify the UI a fair bit by removing the bottom bar completely. QuickLook would be triggered by the space key when a file is selected in the Tree View's table and switching between the views could happen via menu item (with shortcut). I put the remote operations at the bottom under the source view because they > relate to the selection in the source view and not which commit is selected. The standard UI for this is the button bar. See attached screen shot. The various actions would be available from the gear menu or via contextual menu in the source list. Clean up the commit message > < > http://github.com/brotherbard/gitx/commit/9a536fc92a83c2fba408ad6d98b281f449882bad > > > - allow the commit message text to wrap > - use Menlo on systems that have it > I like this as a possible middle ground to the previous discussion on commit messages. The text wrapping is a pretty big win for usability in my opinion. > I think the best way to integrate this is to split it in semantically > > separate patches and post those to the list. That way we can decide > > which features are appropriate and which need more work. > > OK, I'll probably work on that this weekend when I have more time. However, > given recent discussions, I'll just list three here that are related. > I'm pretty excited about a lot of the stuff you have in your branch Nathan. Some very nice work. I'm looking forward to discussing these features for 0.8 and beyond. Kevin
<<attachment: button-bar.png>>
