Mostly LGTM.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16002
File dev/core/src/com/google/gwt/dev/DevMode.java (right):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16002#newcode186
dev/core/src/com/google/gwt/dev/DevMode.java:186: protected interface
HostedModeOptions extends HostedModeBaseOptions,
While you are here, want to rename HostedMode=>DevMode?

http://gwt-code-reviews.appspot.com/361801/diff/15001/16002#newcode218
dev/core/src/com/google/gwt/dev/DevMode.java:218: return warDir;
Are we sure -out is fully compatible with -war?  Seems like war has an
extra directory level over what -out had.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16007
File user/build.xml (left):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16007#oldcode397
user/build.xml:397: <target name="test.noserver"
Can you clarify how we are getting the same coverage of testing
-noserver / DevMode as before?

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009
File user/src/com/google/gwt/junit/JUnitShell.java (left):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009#oldcode146
user/src/com/google/gwt/junit/JUnitShell.java:146: registerHandler(new
ArgHandlerBindAddress(options) {
Where is this handled?

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009
File user/src/com/google/gwt/junit/JUnitShell.java (right):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009#newcode1075
user/src/com/google/gwt/junit/JUnitShell.java:1075: for (String path :
module.getServletPaths()) {
I thought declaring servlets in the module file was deprecated?

http://gwt-code-reviews.appspot.com/361801/diff/15001/16015
File user/test/com/google/gwt/http/server/RequestBuilderTestServlet.java
(right):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16015#newcode48
user/test/com/google/gwt/http/server/RequestBuilderTestServlet.java:48:
if (pathInfo.equals("/setRequestHeader")) {
Why are the servlet paths changing?  Won't this break third-party tests
using servlets?

http://gwt-code-reviews.appspot.com/361801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to