LGTM with a couple of nits.
http://gwt-code-reviews.appspot.com/361801/diff/21001/22010 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/361801/diff/21001/22010#newcode1090 user/src/com/google/gwt/junit/JUnitShell.java:1090: } On 2010/04/21 01:57:40, scottb wrote:
Self explanatory.
Do you need a TODO here about the issue of dev/prod mode race condition? http://gwt-code-reviews.appspot.com/361801/diff/21001/22011 File user/src/com/google/gwt/junit/server/JUnitHostImpl.java (right): http://gwt-code-reviews.appspot.com/361801/diff/21001/22011#newcode115 user/src/com/google/gwt/junit/server/JUnitHostImpl.java:115: HttpServletRequest request = getThreadLocalRequest(); Why is this not inlined here but is inlined below? http://gwt-code-reviews.appspot.com/361801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
