Gracias.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16002
File dev/core/src/com/google/gwt/dev/DevMode.java (right):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16002#newcode186
dev/core/src/com/google/gwt/dev/DevMode.java:186: protected interface
HostedModeOptions extends HostedModeBaseOptions,
No, but I can do that in the follow-up that will kill GWTShell.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16002#newcode218
dev/core/src/com/google/gwt/dev/DevMode.java:218: return warDir;
They are really compatible.  In fact, all my old launch configs for
JUnit with "-out www" look just like what you'd expect.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16007
File user/build.xml (left):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16007#oldcode397
user/build.xml:397: <target name="test.noserver"
user/test/com/google/gwt/junit/client/DevModeOnCompiledScriptTest.java,
explicitly tests what this used to test.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009
File user/src/com/google/gwt/junit/JUnitShell.java (left):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009#oldcode146
user/src/com/google/gwt/junit/JUnitShell.java:146: registerHandler(new
ArgHandlerBindAddress(options) {
This code was to DISABLE -bindAddress by making it an error to specify
it.  The new code simply never adds it in the first place.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009
File user/src/com/google/gwt/junit/JUnitShell.java (right):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16009#newcode1075
user/src/com/google/gwt/junit/JUnitShell.java:1075: for (String path :
module.getServletPaths()) {
Eh, dunno, not totally.  We just verify that they match the web.xml.
For now, it really does seem useful for doing JUnit tests.  Let's
discuss in the future whether we should move in another direction.

http://gwt-code-reviews.appspot.com/361801/diff/15001/16015
File user/test/com/google/gwt/http/server/RequestBuilderTestServlet.java
(right):

http://gwt-code-reviews.appspot.com/361801/diff/15001/16015#newcode48
user/test/com/google/gwt/http/server/RequestBuilderTestServlet.java:48:
if (pathInfo.equals("/setRequestHeader")) {
It's possible some third-party tests will break, yes.  The upshot is,
GWTShellServlet always did it wrong.  If you go back to patchset 1, I
wrote a comment that explains in more detail.

http://gwt-code-reviews.appspot.com/361801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to