@jat: a few last small changes, these are mostly bug/backwards compat
fixes.  It's a fairly small diff from the previous patch, so I commented
all the stuff I changed to make it easy to find.


http://gwt-code-reviews.appspot.com/361801/diff/21001/22009
File user/src/com/google/gwt/junit/JUnit.gwt.xml (right):

http://gwt-code-reviews.appspot.com/361801/diff/21001/22009#newcode41
user/src/com/google/gwt/junit/JUnit.gwt.xml:41: <servlet
path='/junithost/*' class='com.google.gwt.junit.server.JUnitHostImpl'/>
Support for /junithost/loadError.

http://gwt-code-reviews.appspot.com/361801/diff/21001/22010
File user/src/com/google/gwt/junit/JUnitShell.java (right):

http://gwt-code-reviews.appspot.com/361801/diff/21001/22010#newcode1083
user/src/com/google/gwt/junit/JUnitShell.java:1083: }
Jetty will WARN if it can't load a servlet, but keep running, the test
might still pass.

http://gwt-code-reviews.appspot.com/361801/diff/21001/22010#newcode1090
user/src/com/google/gwt/junit/JUnitShell.java:1090: }
Self explanatory.

http://gwt-code-reviews.appspot.com/361801/diff/21001/22011
File user/src/com/google/gwt/junit/server/JUnitHostImpl.java (right):

http://gwt-code-reviews.appspot.com/361801/diff/21001/22011#newcode167
user/src/com/google/gwt/junit/server/JUnitHostImpl.java:167:
getClientDesc(request));
This line was leading to an NPE when called from service(), so I
rejiggered this a tad to pass in the request object explicitly.

http://gwt-code-reviews.appspot.com/361801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to