http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode525
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:525:
Can you add back the "if (pkg == null)" ... error check?  We should
still throw an exception if the named package is not found.  You can
then remove the null check that follows.

http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode542
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:542: }
Please add a unit test for this new functionality to UiBinderTest.

http://gwt-code-reviews.appspot.com/1386803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to