Thanks, updated; PTAL.

http://gwt-code-reviews.appspot.com/1386803/diff/1003/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.java
File user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.java
(right):

http://gwt-code-reviews.appspot.com/1386803/diff/1003/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.java#newcode34
user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.java:34:
Please add a positive test to UiBinderTest.java.  UiBinderTest is run
as part of
the GWT submit queue, so we will be able to catch any issues if
someone makes a
change to UiBInder that breaks this functionality.  You should be able
to
pattern a simple test after one of the existing tests.

You can simplify ClassLookUpTest.ui.xml to contain 2 Labels, one that
requires
stepping through the class hierarchy and one that does not.  I think a
test in
UiBinderTest is sufficient for this change; you don't need the
separate test
class ClassLookupTest.

I went for three labels: normal, one step, and step as far as possible.

Removed ClassLookupTest.java, moved the UIBinder invocation to
UIBinderTest.

http://gwt-code-reviews.appspot.com/1386803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to