Thanks, done as suggested.
Tested w/submit queue, all tests passed. Could you please LGTM/approve?
http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml
File
user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml
(right):
http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml#newcode12
user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml:12:
On 2011/04/01 20:48:12, sbrubaker wrote:
Please add the following to WidgetBasedUi.ui.xml:
In the ui:UiBinder tag
xmlns:gwt2='urn:import:com.google.gwt.user.client'
xmlns:gwt3='urn:import:com'
Update the end of the XML to use the new functionality:
<gwt2:ui.NumberLabel ui:field='myNumberLabel2'
format='{MY_NUMBER_FORMAT}' />
<gwt3:google.gwt.user.client.ui.ValueLabel ui:field='myValueLabel'
renderer='{doubleRenderer}' />
You should then be able to remove ClassLookupTest.ui.xml.
Done.
http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
(right):
http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java#newcode636
user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java:636: }
On 2011/04/01 20:48:12, sbrubaker wrote:
Shouldn't need to modify UiBinderTest.java if you move your ui
declaration into
WidgetBasedUi.ui.xml. The existing test coverage will test the new
functionality, so after you make that update please test via the GWT
SQ and
you'll be good to go.
Done.
http://gwt-code-reviews.appspot.com/1386803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
