Thanks, updated as suggested.
http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode525 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:525: On 2011/03/22 18:29:42, sbrubaker wrote:
Can you add back the "if (pkg == null)" ... error check? We should
still throw
an exception if the named package is not found. You can then remove
the null
check that follows.
Done. http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode542 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:542: } On 2011/03/22 18:29:42, sbrubaker wrote:
Please add a unit test for this new functionality to UiBinderTest.
Done; verified that the test fails without the change and passes with. http://gwt-code-reviews.appspot.com/1386803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
