Comments added to clarify the various changes made.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/super/com/google/gwt/emul/java/util/IdentityHashMap.java
File user/super/com/google/gwt/emul/java/util/IdentityHashMap.java
(right):

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/super/com/google/gwt/emul/java/util/IdentityHashMap.java#newcode45
user/super/com/google/gwt/emul/java/util/IdentityHashMap.java:45:
private V exposeValue;
This was the problem causing serialization failure.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTest.java
File user/test/com/google/gwt/user/client/rpc/CollectionsTest.java
(right):

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTest.java#newcode386
user/test/com/google/gwt/user/client/rpc/CollectionsTest.java:386: });
This test for identityHashMap was previously missing.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTest.java#newcode475
user/test/com/google/gwt/user/client/rpc/CollectionsTest.java:475:
LinkedList was also untested.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java
File
user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java
(left):

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java#oldcode24
user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java:24:
import
com.google.gwt.user.client.rpc.TestSetFactory.MarkerTypeLinkedHashSet;
This was unused. We do not have a serializer for LinkedHashSet.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java#oldcode120
user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java:120:
LinkedHashSet<MarkerTypeLinkedHashSet> value)
No serializer for this, so no need to test.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestServiceAsync.java
File
user/test/com/google/gwt/user/client/rpc/CollectionsTestServiceAsync.java
(left):

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestServiceAsync.java#oldcode104
user/test/com/google/gwt/user/client/rpc/CollectionsTestServiceAsync.java:104:
AsyncCallback<LinkedHashSet<MarkerTypeLinkedHashSet>> callback);
We never use this method because we do not serialize LinkedhashSet
objects.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/InheritanceTest.java
File user/test/com/google/gwt/user/client/rpc/InheritanceTest.java
(right):

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/InheritanceTest.java#newcode27
user/test/com/google/gwt/user/client/rpc/InheritanceTest.java:27: *
Tests RPC serialization of classes without custom serializers.
Simply added a comment.

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/TestSetFactory.java
File user/test/com/google/gwt/user/client/rpc/TestSetFactory.java
(left):

http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/TestSetFactory.java#oldcode492
user/test/com/google/gwt/user/client/rpc/TestSetFactory.java:492: return
set;
Removed unused code.

http://gwt-code-reviews.appspot.com/1395804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to