The work for UmbrellaException is rolled in here because testing relies
on the RPC test framework, which is not present in the Event testing
code. The UmbrellaException code could be placed in a separate
changelist if we created Exceptions-specific classes out the
TestSetFactory and TestSetValidtor code. I'm happy to do that if it is
considered worthwhile - I tend to think not.
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/src/com/google/gwt/event/shared/UmbrellaException.java
File user/src/com/google/gwt/event/shared/UmbrellaException.java
(right):
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/src/com/google/gwt/event/shared/UmbrellaException.java#newcode38
user/src/com/google/gwt/event/shared/UmbrellaException.java:38:
this.causes = new HashSet<Throwable>();
On 2011/04/04 23:12:53, scottb wrote:
Instead of duplicating code, do "this(new HashSet<Throwable>()).
Done.
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java
File user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java
(right):
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java#newcode23
user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java:23:
public interface ExceptionsTestService extends RemoteService {
On 2011/04/04 23:12:53, scottb wrote:
There's an annotation you can use on this class that keeps you from
having to do
an explicit ServiceDefTarget.setServiceEntryPoint() call in the test
code.
Do you know what the annotation is? None of the other RPC test services
use it.
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/ExceptionsTestServiceAsync.java
File
user/test/com/google/gwt/user/client/rpc/ExceptionsTestServiceAsync.java
(right):
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/ExceptionsTestServiceAsync.java#newcode2
user/test/com/google/gwt/user/client/rpc/ExceptionsTestServiceAsync.java:2:
* Copyright 2008 Google Inc.
On 2011/04/04 23:12:53, scottb wrote:
Update copyright year. I think some other new files had this too.
Done.
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java
File user/test/com/google/gwt/user/client/rpc/TestSetValidator.java
(right):
http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java#newcode287
user/test/com/google/gwt/user/client/rpc/TestSetValidator.java:287: }
On 2011/04/04 23:12:53, scottb wrote:
A nice pattern for this goes something like,
if ((expected == null) != (actual == null)) {
return false;
}
Done.
http://gwt-code-reviews.appspot.com/1395804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
