High-level, can you just add in the test for LinkedHashSet instead of removing all the infrastructure for it?
http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java File user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java (left): http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java#oldcode120 user/test/com/google/gwt/user/client/rpc/CollectionsTestService.java:120: LinkedHashSet<MarkerTypeLinkedHashSet> value) I think we should actually be testing this anyway; even if there's not a custom serializer, it'd still be good to verify that it works correctly. http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java File user/test/com/google/gwt/user/client/rpc/TestSetValidator.java (right): http://gwt-code-reviews.appspot.com/1395804/diff/1/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java#newcode420 user/test/com/google/gwt/user/client/rpc/TestSetValidator.java:420: return true; Can you explain this implementation? I would have thought the linked list should ensure correct ordering of entries, which would imply using the equals(Iterator,Iterator) method instead of List.contains(). http://gwt-code-reviews.appspot.com/1395804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
