http://gwt-code-reviews.appspot.com/1395804/diff/11/user/test/com/google/gwt/user/client/rpc/TestSetFactory.java File user/test/com/google/gwt/user/client/rpc/TestSetFactory.java (right):
http://gwt-code-reviews.appspot.com/1395804/diff/11/user/test/com/google/gwt/user/client/rpc/TestSetFactory.java#newcode508 user/test/com/google/gwt/user/client/rpc/TestSetFactory.java:508: return map; Sorry for not catching this the first time, but I realized looking at the TestSetValidator code for this, that this is kind of squirrelly. It skirts around the issue of identity in various ways. I would propose you define two enums, a key enum type and a value enum type, and use that for the IdentityHashMap test. Then you can actually get the correct Object identity semantics, since enum values must serialize as singleton objects. And it should make the test code in TestSetValidator much simpler. http://gwt-code-reviews.appspot.com/1395804/diff/11/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java File user/test/com/google/gwt/user/client/rpc/TestSetValidator.java (right): http://gwt-code-reviews.appspot.com/1395804/diff/11/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java#newcode367 user/test/com/google/gwt/user/client/rpc/TestSetValidator.java:367: Set<?> mapEntries = map.entrySet(); Hoist this out of the loop. http://gwt-code-reviews.appspot.com/1395804/diff/11/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java#newcode386 user/test/com/google/gwt/user/client/rpc/TestSetValidator.java:386: return false; style: always use curly braces http://gwt-code-reviews.appspot.com/1395804/diff/11/user/test/com/google/gwt/user/client/rpc/TestSetValidator.java#newcode418 user/test/com/google/gwt/user/client/rpc/TestSetValidator.java:418: } No need to check here, equals() will. http://gwt-code-reviews.appspot.com/1395804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
