On 2011/04/05 14:19:32, schenney wrote:
The work for UmbrellaException is rolled in here because testing
relies on the
RPC test framework, which is not present in the Event testing code.
The
UmbrellaException code could be placed in a separate changelist if we
created
Exceptions-specific classes out the TestSetFactory and TestSetValidtor
code. I'm
happy to do that if it is considered worthwhile - I tend to think not.
At this point, it probably doesn't make sense to go redo it. But going forward it probably doesn't make sense for the RPC tests should be a catch-all for everything that can be serialized. For non-collections stuff, TestSetFactory / TestSetValidator is really a lot more infrastructure than you really need anyway. It makes sense that the RPC system tests the core JRE classes (which don't, themselves, depend on RPC), but for other unrelated subsystems they should probably be separated out. Anyway, I'm rambling, I think it's fine to commit as is. http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java File user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java (right): http://gwt-code-reviews.appspot.com/1395804/diff/8001/user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java#newcode23 user/test/com/google/gwt/user/client/rpc/ExceptionsTestService.java:23: public interface ExceptionsTestService extends RemoteService { Googling.... it's @RemoteServiceRelativePath. The other tests are all older than the annotation. http://gwt-code-reviews.appspot.com/1395804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
