Thomas Broyer has posted comments on this change.
Change subject: Implemented handling of GwtIncompatible annotations.
......................................................................
Patch Set 2:
(3 comments)
I bet you'll please a whole lot of users with this change! ;-)
+1 to adding a GwtIncompatible annotation in GWT proper; we don't want to
force people to use Guava or make their own GwtIncompatible annotation, do
we?
....................................................
Commit Message
Line 7: Implemented handling of GwtIncompatible annotations.
Could you reference issue 3769 in the commit message?
I reopened it and assigned it to you.
Line 9: Any class, method or field that has an annotation of type
GwtIncompatible
Maybe this should rather say "any annotation named GwtIncompatible"?
I don't expect many people to read the commit history, but I originally
thought you were adding a GwtIncompatible annotation, then saw it was only
in dev/core/test and eventually only understood by looking at the other
changes in the patch.
....................................................
File
user/test/com/google/gwt/dev/jjs/test/gwtincompatible/GwtIncompatible.java
Line 26: * <a href="http://code.google.com/webtoolkit/";>Google Web
Toolkit</a> (GWT).
Link should be developers.google.com, and as we're in the process of
removing the "Google" word from GWT, maybe just make the link text "GWT"
rather than "Google Web Toolkit" (we'll have to revisit all the code
though, so no big deal)
--
To view, visit https://gwt-review.googlesource.com/2320
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f995d107b9e24fb7afb8aca95ab99b35f561216
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
