Roberto Lublinerman has posted comments on this change.
Change subject: Implemented handling of GwtIncompatible annotations.
......................................................................
Patch Set 3:
(5 comments)
It seems extremely wasteful to generate bytecode, as it is only needed by
devmode (maybe also by generators?). Removing bytecode generation might
result in a reduction of compile time. We could explore removing the
bytecode generation, maybe with a flag?
....................................................
File user/src/com/google/gwt/core/shared/GwtIncompatible.java
Line 26: * Any class, method or field with an annotation @GwtIncompatible
is ignored by the compiler.
Done
Line 28: * e.g.
Done
Line 59: * }
Done
Line 68: * Some attribute fields useful for documentation purposes. Form
the compiler perspective
Done
....................................................
File user/test/com/google/gwt/dev/jjs/test/GwtIncompatibleTest.java
Line 63: assertEquals(-1, b.getClassFooNbrConstructors());
It seems that we are actually compiling the sources we see to bytecode. I
guess by the call to unit.GenerateCode in
org.eclipse.jdt.internal.compiler.Compiler#process.
--
To view, visit https://gwt-review.googlesource.com/2320
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f995d107b9e24fb7afb8aca95ab99b35f561216
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
