Brian Slesinsky has posted comments on this change.
Change subject: Implemented handling of GwtIncompatible annotations.
......................................................................
Patch Set 4:
Looks like we save the bytecode to a map named JdtCompiler.binaryTypes in
JdtCompiler.CompileImpl.process(). This map is used to implement
INameEnvironmentImpl which we pass to the JdtCompiler for type lookup. It
can also read bytecode from generators and falls back to .class files in
the compiler's classpath.
It seems like a good source of confusing bugs. For the purposes of this
change, actual source code sent to the GWTCompiler takes priority and so
@GwtIncompatible will be honored in source. If there are any
@GwtIncompatible annotations in the classpath then they wouldn't be
stripped, but I think it only matters for the JDT's type checking.
--
To view, visit https://gwt-review.googlesource.com/2320
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f995d107b9e24fb7afb8aca95ab99b35f561216
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
