Roberto Lublinerman has posted comments on this change.
Change subject: Implemented handling of GwtIncompatible annotations.
......................................................................
Patch Set 2:
(10 comments)
....................................................
Commit Message
Line 7: Implemented handling of GwtIncompatible annotations.
Done
Line 9: Any class, method or field that has an annotation of type
GwtIncompatible
Done
....................................................
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
Line 235: private class ParserImpl extends Parser {
I sort of like it as a private static class better, similar to
CompilerImpl. But I defer to your judgement.
Line 261: * Filters out types that have an annotation of class {@code
*.GwtIncompatible}; recursibly
stripGwtIncompatibleTypes and stripGwtIncompatibleElements are now one as
per your suggestion.
Line 270: tyDecl.memberTypes =
stripGwtIncompatibleElements(tyDecl.memberTypes);
Done
Line 282: * Filters out methods that have an annotation of class
{@code *.GwtIncompatible}.
Done
Line 305: * Filters out fields that have an annotation of class {@code
*.GwtIncompatible}.
Done
Line 333: private TypeDeclaration[]
stripGwtIncompatibleElements(TypeDeclaration[] types) {
Done
....................................................
File
user/test/com/google/gwt/dev/jjs/test/gwtincompatible/GwtIncompatible.java
Line 24: * The presence of this annotation on a method indicates that the
method may
Done
Line 26: * <a href="http://code.google.com/webtoolkit/";>Google Web
Toolkit</a> (GWT).
Done
--
To view, visit https://gwt-review.googlesource.com/2320
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f995d107b9e24fb7afb8aca95ab99b35f561216
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
