Brian Slesinsky has posted comments on this change.
Change subject: Implemented handling of GwtIncompatible annotations.
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
This seems fine. I don't quite understand how it works in dev mode. I guess
we must always generate Java bytecode from source that went through the JDT
compiler?
....................................................
File user/src/com/google/gwt/core/shared/GwtIncompatible.java
Line 26: * Any class, method or field with an annotation @GwtIncompatible
is ignored by the compiler.
"annotation named GwtIncompatible"
s/compiler/GWT compiler/
Line 28: * e.g.
s/e.g./For example:/
Line 59: * }
"Warning: this may have surprising effects when combined with method
overloading or inheritance."
Line 68: * Some attribute fields useful for documentation purposes. Form
the compiler perspective
"An attribute that can be used to explain why the code is incompatible. All
attributes on a GwtIncompatible annotation are ignored by the GWT compiler."
....................................................
File user/test/com/google/gwt/dev/jjs/test/GwtIncompatibleTest.java
Line 63: assertEquals(-1, b.getClassFooNbrConstructors());
This passes in dev mode as well? I'm a little surprised.
--
To view, visit https://gwt-review.googlesource.com/2320
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f995d107b9e24fb7afb8aca95ab99b35f561216
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
